Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numbering in Android tracing instructions markdown #1227

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

kayayarai
Copy link
Contributor

What does this PR do?

Fixes ordered list numbering

Motivation

maintenance

Additional Notes

docs only change

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kayayarai kayayarai requested review from a team as code owners January 9, 2023 21:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #1227 (44389e7) into master (4071ef8) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
- Coverage   82.42%   82.27%   -0.15%     
==========================================
  Files         353      353              
  Lines       11795    11802       +7     
  Branches     2007     2008       +1     
==========================================
- Hits         9721     9709      -12     
- Misses       1470     1476       +6     
- Partials      604      617      +13     
Impacted Files Coverage Δ
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 80.77% <0.00%> (-7.69%) ⬇️
...android/v2/core/internal/DatadogContextProvider.kt 80.00% <0.00%> (-4.62%) ⬇️
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 75.00% <0.00%> (-3.85%) ⬇️
...in/com/datadog/android/log/internal/LogsFeature.kt 87.10% <0.00%> (-3.23%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 85.71% <0.00%> (-1.97%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 71.43% <0.00%> (-1.68%) ⬇️
...android/log/internal/domain/DatadogLogGenerator.kt 95.97% <0.00%> (-0.67%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.82% <0.00%> (-0.55%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.05% <0.00%> (-0.37%) ⬇️
...n/kotlin/com/datadog/android/ktx/rum/ContextExt.kt 100.00% <0.00%> (ø)
... and 2 more

@kayayarai kayayarai merged commit 4bd3586 into master Jan 10, 2023
@kayayarai kayayarai deleted the kari/fix-md-format branch January 10, 2023 15:20
@xgouchet xgouchet added this to the 1.18.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants