-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-2038 Use safe context for directBootAware host apps #1209
Conversation
d6747f1
to
3875e69
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1209 +/- ##
===========================================
- Coverage 82.31% 82.29% -0.02%
===========================================
Files 353 353
Lines 11795 11799 +4
Branches 2007 2009 +2
===========================================
+ Hits 9708 9709 +1
- Misses 1475 1476 +1
- Partials 612 614 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some small nits, otherwise looks good for docs
Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com>
// When the host app uses the `directBootAware` flag on a file encrypted device, | ||
// the app can wake up during the boot sequence before the device is unlocked | ||
// This mean any file I/O or access to shared preferences will throw an exception | ||
// This safe context creates a device-protected storage which can be used for non sensitive | ||
// data. It should not be used to store the data captured by the SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// When the host app uses the `directBootAware` flag on a file encrypted device, | |
// the app can wake up during the boot sequence before the device is unlocked | |
// This mean any file I/O or access to shared preferences will throw an exception | |
// This safe context creates a device-protected storage which can be used for non sensitive | |
// data. It should not be used to store the data captured by the SDK. | |
// When the host app uses the `directBootAware` flag on a file encrypted device, | |
// the app can wake up during the boot sequence before the device is unlocked | |
// This mean any file I/O or access to shared preferences will throw an exception | |
// This safe context creates a device-protected storage which can be used for non-sensitive | |
// data. It should not be used to store the data captured by the SDK. |
Fixes #854
Fixes #1116
What does this PR do?
Uses the
createDeviceProtectedStorageContext
to ensure Kronos works in all edge cases.Note that the safe context should only be used for Kronos.