Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CodeQL analysis #1204

Merged
merged 6 commits into from
Dec 29, 2022
Merged

Enable CodeQL analysis #1204

merged 6 commits into from
Dec 29, 2022

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Dec 21, 2022

What does this PR do?

Commit made on top of #1203 to fix compile issues
The custom detekt rules we have was using soon to be deprecated APIs in Kotlin, which made the build fail

Motivation

It is a part of Datadog compliance requirements to regularly perform code-scanning on all the customer installed code

@xgouchet xgouchet requested a review from a team as a code owner December 21, 2022 09:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #1204 (bb895f6) into develop (7da4be4) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1204      +/-   ##
===========================================
- Coverage    82.31%   82.28%   -0.03%     
===========================================
  Files          353      353              
  Lines        11795    11795              
  Branches      2007     2007              
===========================================
- Hits          9708     9705       -3     
+ Misses        1475     1474       -1     
- Partials       612      616       +4     
Impacted Files Coverage Δ
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 76.92% <0.00%> (-3.85%) ⬇️
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 86.27% <0.00%> (-2.94%) ⬇️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 95.24% <0.00%> (-2.38%) ⬇️
...core/internal/system/DefaultAndroidInfoProvider.kt 83.02% <0.00%> (-1.89%) ⬇️
...in/com/datadog/android/log/internal/LogsFeature.kt 87.10% <0.00%> (-1.61%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 88.94% <0.00%> (-1.38%) ⬇️
...g/android/rum/internal/domain/scope/RumEventExt.kt 94.81% <0.00%> (-0.47%) ⬇️
...android/v2/core/internal/DatadogContextProvider.kt 81.54% <0.00%> (ø)
...rc/main/java/com/datadog/opentracing/DDTracer.java 56.49% <0.00%> (+0.42%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 93.37% <0.00%> (+0.55%) ⬆️
... and 4 more

@xgouchet xgouchet changed the title Xgouchet/codeql Enable CodeQL analysis Dec 21, 2022
@xgouchet xgouchet merged commit 120224b into develop Dec 29, 2022
@xgouchet xgouchet deleted the xgouchet/codeql branch December 29, 2022 13:22
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants