Improve batch upload wait timeout handling #1182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change improves lock handling scenario in the batch upload. Before, if any exception would happen during the batch upload if
Storage#readNextBatch
is async (which is not the case right now), lock would be removed only after timeout. Now lock is removed immediately.This is mostly a safeguard if at any point
Storage#readNextBatch
becomes async, but we probably need to revert the switch to async-like API in the upload pipeline back to the blocking API, because async one doesn't really bring any benefit and actually makes code more complex.Review checklist (to be filled by reviewers)