-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTG-8 Apply new detekt configuration #1180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
force-pushed
the
xgouchet/MTG-8/detekt
branch
from
December 8, 2022 16:02
88723c4
to
7703c30
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1180 +/- ##
===========================================
- Coverage 82.31% 82.26% -0.04%
===========================================
Files 353 353
Lines 11778 11790 +12
Branches 2006 2005 -1
===========================================
+ Hits 9694 9699 +5
- Misses 1470 1475 +5
- Partials 614 616 +2
|
mariusc83
requested changes
Dec 9, 2022
library/dd-sdk-android-session-replay/clone_session_replay_schema.gradle.kts
Outdated
Show resolved
Hide resolved
library/dd-sdk-android-session-replay/clone_session_replay_schema.gradle.kts
Outdated
Show resolved
Hide resolved
0xnm
reviewed
Dec 9, 2022
dd-sdk-android/src/main/kotlin/com/datadog/android/DatadogInterceptor.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/com/datadog/android/core/internal/persistence/file/batch/BatchFileDataWriter.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/datadog/android/core/internal/persistence/file/batch/BatchFileOrchestratorTest.kt
Outdated
Show resolved
Hide resolved
instrumented/nightly-tests/src/main/kotlin/com/datadog/android/nightly/activities/Constants.kt
Outdated
Show resolved
Hide resolved
tools/detekt/src/main/kotlin/com/datadog/tools/detekt/rules/InvalidStringFormat.kt
Show resolved
Hide resolved
tools/unit/src/main/kotlin/com/datadog/tools/unit/ConditionWatcher.kt
Outdated
Show resolved
Hide resolved
0xnm
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
mariusc83
approved these changes
Dec 12, 2022
xgouchet
force-pushed
the
xgouchet/MTG-8/detekt
branch
from
December 12, 2022 13:38
10deac9
to
3d1c451
Compare
xgouchet
force-pushed
the
xgouchet/MTG-8/detekt
branch
from
December 12, 2022 14:07
3d1c451
to
be1bce6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the shared static analysis job with an updated detekt configuration