Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused PayloadFormat and SdkEndpoint classes from SDK v2 APIs #1161

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Remove unused PayloadFormat and SdkEndpoint classes from SDK v2 APIs #1161

merged 1 commit into from
Nov 25, 2022

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Nov 25, 2022

What does this PR do?

This PR removes classes which were created for SDK v2, but are not used in the end.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner November 25, 2022 09:53
@0xnm 0xnm merged commit 7dc96cc into feature/sdkv2 Nov 25, 2022
@0xnm 0xnm deleted the nogorodnikov/remove-unused-classes-sdkv2 branch November 25, 2022 13:35
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plousada plousada plousada approved these changes

@xgouchet xgouchet xgouchet approved these changes

Assignees
No one assigned
Labels
size-tiny
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@0xnm @xgouchet @plousada