RUMM-2754: Create implementation of InternalLogger #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
force-pushed
the
nogorodnikov/rumm-2754/create-implementation-of-internal-logger
branch
from
737fb93 to
cf0fddb
Compare
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1155 +/- ##
=================================================
+ Coverage 82.28% 82.31% +0.03%
=================================================
Files 353 354 +1
Lines 11796 11822 +26
Branches 2007 2012 +5
=================================================
+ Hits 9706 9731 +25
- Misses 1465 1468 +3
+ Partials 625 623 -2
|
mariusc83
reviewed
Nov 24, 2022
| attributes: Map<String, Any?> | ||
| ) { | ||
| when (target) { | ||
| // TODO RUMM-2764 we should remove sdkLogger, devLogger and telemetry |
| error: Throwable?, | ||
| attributes: Map<String, Any?> | ||
| ) { | ||
| devLogger.log( |
There was a problem hiding this comment.
you don't want to pass sdkLogger, devLogger and telemetry as dependencies or the problem is that they cannot be yet initialized ?
There was a problem hiding this comment.
Yes, don't want to reference them in the constructor. Anyway it has no real benefit (other than mocking).
0xnm
deleted the
nogorodnikov/rumm-2754/create-implementation-of-internal-logger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simple implementation of
InternalLoggerinterface which forwards logs according to the target specified.Task RUMM-2764 created to start using it in the codebase, not a part of SDK v2 goals.
Review checklist (to be filled by reviewers)