-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device.architecture to logs #1140
Conversation
The device architecture is needed for Flutter symbolication of logs
Codecov Report
@@ Coverage Diff @@
## develop #1140 +/- ##
===========================================
+ Coverage 83.17% 83.20% +0.02%
===========================================
Files 274 274
Lines 9462 9470 +8
Branches 1540 1540
===========================================
+ Hits 7870 7879 +9
Misses 1152 1152
+ Partials 440 439 -1
|
5e1fdeb
to
2de7fa4
Compare
@@ -92,7 +92,7 @@ internal object RuntimeConfig { | |||
|
|||
val stringAttributes = mapOf( | |||
"version_name" to BuildConfig.VERSION_NAME, | |||
"device" to Build.DEVICE, | |||
"build_device" to Build.DEVICE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we revert this change now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch. I actually thought I did revert it.
2de7fa4
to
3b026cc
Compare
What does this PR do?
This adds a
device.architecture
property to logs. Device is kept as an object for potential future expansionMotivation
The device architecture is needed for Flutter symbolication of logs.
Review checklist (to be filled by reviewers)