Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device.architecture to logs #1140

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

fuzzybinary
Copy link
Member

@fuzzybinary fuzzybinary commented Nov 9, 2022

What does this PR do?

This adds a device.architecture property to logs. Device is kept as an object for potential future expansion

Motivation

The device architecture is needed for Flutter symbolication of logs.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

The device architecture is needed for Flutter symbolication of logs
@fuzzybinary fuzzybinary requested a review from a team as a code owner November 9, 2022 21:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #1140 (2de7fa4) into develop (931b063) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1140      +/-   ##
===========================================
+ Coverage    83.17%   83.20%   +0.02%     
===========================================
  Files          274      274              
  Lines         9462     9470       +8     
  Branches      1540     1540              
===========================================
+ Hits          7870     7879       +9     
  Misses        1152     1152              
+ Partials       440      439       -1     
Impacted Files Coverage Δ
...n/com/datadog/android/core/internal/CoreFeature.kt 91.74% <100.00%> (+0.03%) ⬆️
...adog/android/error/internal/CrashReportsFeature.kt 100.00% <100.00%> (ø)
.../src/main/kotlin/com/datadog/android/log/Logger.kt 96.06% <100.00%> (+0.03%) ⬆️
...atadog/android/log/internal/domain/LogGenerator.kt 99.07% <100.00%> (+0.05%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 75.00% <0.00%> (-25.00%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.65% <0.00%> (-0.42%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 72.32% <0.00%> (ø)
...core/internal/system/DefaultAndroidInfoProvider.kt 82.61% <0.00%> (ø)
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 88.11% <0.00%> (+0.54%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 93.33% <0.00%> (+0.56%) ⬆️
... and 1 more

@xgouchet xgouchet added the size-small This PR is small sized label Nov 11, 2022
@fuzzybinary fuzzybinary force-pushed the jward/RUMM-2729-add-error-architecture branch from 5e1fdeb to 2de7fa4 Compare November 15, 2022 14:46
@@ -92,7 +92,7 @@ internal object RuntimeConfig {

val stringAttributes = mapOf(
"version_name" to BuildConfig.VERSION_NAME,
"device" to Build.DEVICE,
"build_device" to Build.DEVICE,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we revert this change now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch. I actually thought I did revert it.

@fuzzybinary fuzzybinary force-pushed the jward/RUMM-2729-add-error-architecture branch from 2de7fa4 to 3b026cc Compare November 15, 2022 15:46
@fuzzybinary fuzzybinary merged commit 31fd86f into develop Nov 16, 2022
@fuzzybinary fuzzybinary deleted the jward/RUMM-2729-add-error-architecture branch November 16, 2022 13:54
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small This PR is small sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants