RUMM-2699: Remove RumEventSourceProvider #1119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change removes
RumEventSourceProvider
, because we shouldn't accessCoreFeature
(it won't be exposed as public API), so we cannot readCoreFeature#sourceName
at theDatadogRumMonitor
construction time and should readDatadogContext#source
instead which is available in the Event Write Context.Calls to
RumEventSourceProvider
are replaced by the companion extensions of the correspondingSource
objects which try to parse the value fromDatadogContext#source
in the safe manner.Review checklist (to be filled by reviewers)