RUMM-2608: Use event write context for Traces #1106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR brings the usage of event write context (which can be retrieved by calling
withWriteContext
) for traces.It is done by changing the
TraceWriter
so that it requests event write context for the collection ofDDSpan
to write.EWC will be requests only once, so that DD context is the same for all the spans to be written.
Also introduced
ContextAwareMapper
andContextAwareSerializer
, because both mapping (from legacyDDSpan
toSpanEvent
and serialization) requireDatadogContext
access, and options like to create them each time inside EWC or usePair<DatadogContext, T>
as argument seemed less reasonable to me.Review checklist (to be filled by reviewers)