Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to top level project for nexusPublishing extension #1096

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

fuzzybinary
Copy link
Member

What does this PR do?

It appears the nexusPublishing extension only evaluates whether a deployment goes to staging or not at the Project level, so we need to add the version at that level in order for snapshot builds to go through

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@fuzzybinary fuzzybinary requested a review from a team as a code owner October 20, 2022 16:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #1096 (21cf147) into develop (3f38162) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1096      +/-   ##
===========================================
- Coverage    83.27%   83.23%   -0.04%     
===========================================
  Files          273      273              
  Lines         9348     9348              
  Branches      1503     1503              
===========================================
- Hits          7784     7780       -4     
- Misses        1146     1151       +5     
+ Partials       418      417       -1     
Impacted Files Coverage Δ
...ain/java/com/datadog/opentracing/PendingTrace.java 56.03% <0.00%> (-4.31%) ⬇️
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 86.54% <0.00%> (-1.92%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 54.81% <0.00%> (-1.67%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.61% <0.00%> (+0.57%) ⬆️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 88.65% <0.00%> (+1.08%) ⬆️
...ndroid/core/internal/persistence/file/EventMeta.kt 90.00% <0.00%> (+10.00%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 100.00% <0.00%> (+25.00%) ⬆️

@fuzzybinary fuzzybinary force-pushed the RUMM-2579-snapshot-builds branch from a85a13d to 21cf147 Compare October 20, 2022 18:20
@fuzzybinary fuzzybinary merged commit 3cf6fac into develop Oct 21, 2022
@fuzzybinary fuzzybinary deleted the RUMM-2579-snapshot-builds branch October 21, 2022 12:20
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants