Publish SNAPSHOT builds to sonatype on pushes to develop #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusc83
reviewed
Oct 20, 2022
| @@ -317,6 +326,7 @@ publish:release-timber: | |||
| tags: [ "runner:main" ] | |||
| only: | |||
| - tags | |||
| - develop | |||
There was a problem hiding this comment.
if you add this here, doesn't this mean that this task will always be performed when develop builds ? That means we are going to push snapshots every time we merge something in develop, is that correct ?
xgouchet
approved these changes
Oct 20, 2022
| @@ -317,6 +326,7 @@ publish:release-timber: | |||
| tags: [ "runner:main" ] | |||
| only: | |||
| - tags | |||
| - develop | |||
0xnm
reviewed
Oct 20, 2022
| @@ -17,7 +17,7 @@ object AndroidConfig { | |||
| const val MIN_SDK_FOR_COMPOSE = 21 | |||
| const val BUILD_TOOLS_VERSION = "31.0.0" | |||
|
|
|||
| val VERSION = Version(1, 15, 0, Version.Type.Dev) | |||
| val VERSION = Version(1, 15, 0, Version.Type.Snapshot) | |||
There was a problem hiding this comment.
is it enough to publish the snapshot on Sonatype? will it skip staging/approval step if version has -SNAPSHOT suffix? Or will it be some other PR?
There was a problem hiding this comment.
Sonatype will automatically skip staging based on the -SNAPSHOT suffix
mariusc83
approved these changes
Oct 20, 2022
fuzzybinary
force-pushed
the
RUMM-2579-snapshot-builds
branch
from
77bdb3a to
c1dbcbd
Compare
xgouchet
approved these changes
Oct 20, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1093 +/- ##
===========================================
+ Coverage 83.20% 83.23% +0.02%
===========================================
Files 273 273
Lines 9348 9348
Branches 1503 1503
===========================================
+ Hits 7778 7780 +2
- Misses 1149 1151 +2
+ Partials 421 417 -4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add 'SNAPSHOT' as a version tag, and default new versions to it. Change the build so that
developtriggers allpublishstages.Motivation
The cross platform frameworks would like to work from SNAPSHOTS in order to speed up development.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)