RUMM-2659 editable additional attributes #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
changed the title
xgouchet
force-pushed
the
xgouchet/RUMM-2659/editable_additional_attributes
branch
from
8847c50 to
e80ee0e
Compare
|
I'm not super familiar with the generator but LGTM. |
plousada
approved these changes
Oct 17, 2022
mariusc83
approved these changes
Oct 18, 2022
0xnm
approved these changes
Oct 18, 2022
| val logWithoutAttributes = fakeLog.copy(additionalProperties = emptyMap()) | ||
| val attributes = forge.aMap { | ||
| val logWithoutAttributes = fakeLog.copy(additionalProperties = mutableMapOf()) | ||
| val attributes = forge.aMap<String, Any?> { |
There was a problem hiding this comment.
Because the compiler can't resolve it
There was a problem hiding this comment.
Clear now. I just asked because my IDE was completely fine with removing the type, but after explicit compilation the error was raised indeed.
Codecov Report
@@ Coverage Diff @@
## develop #1089 +/- ##
===========================================
- Coverage 83.27% 83.25% -0.02%
===========================================
Files 273 273
Lines 9342 9344 +2
Branches 1501 1502 +1
===========================================
Hits 7779 7779
- Misses 1146 1149 +3
+ Partials 417 416 -1
|
xgouchet
deleted the
xgouchet/RUMM-2659/editable_additional_attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow edition of custom attributes for RUM events.
Motivation
The context's additional attributes were immutable by default, meaning there was no way to edit them within the EventMapper callback.