Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DatadogCore initialization tests #1056

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Update DatadogCore initialization tests #1056

merged 1 commit into from
Sep 28, 2022

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Sep 27, 2022 •
edited
Loading

What does this PR do?

This change makes commented tests in DatadogCoreInitializationTest.kt working again.

It was already done #1055, but since that PR is closed, taking it from there.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner September 27, 2022 11:18
@xgouchet xgouchet added the size-medium This PR is medium sized label Sep 27, 2022
@0xnm 0xnm merged commit bfe770a into feature/sdkv2 Sep 28, 2022
@0xnm 0xnm deleted the nogorodnikov/update-datadog-core-initialization-tests branch September 28, 2022 07:45
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes

Assignees
No one assigned
Labels
size-medium This PR is medium sized
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@0xnm @mariusc83 @xgouchet