-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-2542 Send hasReplay property for RUM events #1054
RUMM-2542 Send hasReplay property for RUM events #1054
Conversation
9de000f
to
580b8d0
Compare
Codecov Report
@@ Coverage Diff @@
## feature/session-replay-vo #1054 +/- ##
=============================================================
+ Coverage 83.26% 83.35% +0.08%
=============================================================
Files 332 343 +11
Lines 10569 10791 +222
Branches 1773 1792 +19
=============================================================
+ Hits 8800 8994 +194
- Misses 1219 1243 +24
- Partials 550 554 +4
|
1dc5b2f
to
99d17a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I just added one comment regarding the assertion removed from the test.
@@ -286,7 +286,6 @@ internal class DatadogCoreTest { | |||
assertThat(testedCore.webViewRumFeature).isNull() | |||
assertThat(testedCore.crashReportsFeature).isNull() | |||
assertThat(testedCore.sessionReplayFeature).isNull() | |||
assertThat(testedCore.contextProvider).isNull() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this line is removed? In the latest version of the SDK v2 branch at least when CoreFeature
is stopped, contextProvider
should return null
.
99d17a7
to
76ec178
Compare
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)