-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-2504: Switch to the SDK v2 storage component #1051
RUMM-2504: Switch to the SDK v2 storage component #1051
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1051 +/- ##
=================================================
+ Coverage 82.83% 82.84% +0.02%
=================================================
Files 306 306
Lines 10080 10089 +9
Branches 1642 1645 +3
=================================================
+ Hits 8349 8358 +9
Misses 1230 1230
Partials 501 501
|
5659de8
to
c059e6b
Compare
val context = contextProvider.context | ||
val eventId = System.identityHashCode(data).toString() | ||
storage.writeCurrentBatch(context) { | ||
pendingWriteEvents[eventId] = data to byteArray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't we concerned that we will keep too much data in HEAP ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. For now we need to store both event and serialized event mostly because of the RUM, but maybe later on with once RUM will start using write scope to perform writes we can change it.
What is your expectation for the memory pressure during SR? How often and how big are going to be events received? I guess concern is mostly because of the bitmaps?
I would propose to add TODO for now. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I am mostly thinking for Bitmaps here, let's benchmark this when we get there and see how it goes.
c059e6b
to
00b79be
Compare
What does this PR do?
This change does a switch to the
Storage
implementation written earlier. While it is not used as it should be in the feature configuration per SDK v2 plan, this change helps to minimize the diff of the transition and makes a proof that new component works.Review checklist (to be filled by reviewers)