RUMM-2423 Add the Sesion Replay MASK_ALL/ALLOW_ALL privacy strategies #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusc83
force-pushed
the
mconstantin/rumm-2424/add-session-replay-v0-privacy-rules
branch
from
4efca7e to
51760c2
Compare
0xnm
reviewed
Sep 7, 2022
| ALLOW_ALL, | ||
|
|
||
| /** | ||
| * Masks all the elements. All the characters in texts will be replaced by X, images will be |
There was a problem hiding this comment.
Not a native speaker, but can we use plural form texts here? @fuzzybinary can you check?
| ) : TextWireframeMapper(viewWireframeMapper) { | ||
|
|
||
| override fun resolveTextValue(textView: TextView): String { | ||
| return String(CharArray(textView.text.length) { CHARACTER_MASK }) |
There was a problem hiding this comment.
question: should we keep spaces at least as is? how browser SR does when applying this mask?
There was a problem hiding this comment.
I am not sure we can do this as it will affect layout. It is kind of a wait and see situations. After some tests on different apps probably we will apply some adjustments.
| right = this.totalPaddingEnd.densityNormalized(pixelsDensity).toLong() | ||
| top = textView.totalPaddingTop.densityNormalized(pixelsDensity).toLong(), | ||
| bottom = textView.totalPaddingBottom.densityNormalized(pixelsDensity).toLong(), | ||
| left = textView.totalPaddingStart.densityNormalized(pixelsDensity).toLong(), |
There was a problem hiding this comment.
won't we have any issues with RTL layout where start is on the right? How SR handles RTL btw?
| @ParameterizedTest | ||
| @MethodSource("textTypefaces") | ||
| fun `M resolve a TextWireframe W map() { TextView with fontStyle }`( | ||
| typeface: Typeface, |
There was a problem hiding this comment.
minor: let's rename to fakeTypeface for the consistency and avoid a possible confusion when this is not specified explicitly.
Base automatically changed from
mconstantin/rumm-2423/snapshot-processor-compute-mutations
to
feature/session-replay-vo
September 8, 2022 07:40
mariusc83
force-pushed
the
mconstantin/rumm-2424/add-session-replay-v0-privacy-rules
branch
from
51760c2 to
539775c
Compare
Codecov Report
@@ Coverage Diff @@
## feature/session-replay-vo #1035 +/- ##
=============================================================
+ Coverage 83.22% 83.32% +0.10%
=============================================================
Files 323 327 +4
Lines 10424 10454 +30
Branches 1734 1737 +3
=============================================================
+ Hits 8675 8710 +35
+ Misses 1210 1208 -2
+ Partials 539 536 -3
|
0xnm
approved these changes
Sep 9, 2022
xgouchet
approved these changes
Sep 9, 2022
mariusc83
deleted the
mconstantin/rumm-2424/add-session-replay-v0-privacy-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)