RUMM-2477: Update Cmake to 3.22.1 #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
force-pushed
the
nogorodnikov/rumm-2477/update-cmake-to-3.22.1
branch
from
a399b1d to
6997fc9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1032 +/- ##
===========================================
+ Coverage 83.20% 83.23% +0.03%
===========================================
Files 272 272
Lines 9256 9256
Branches 1485 1485
===========================================
+ Hits 7701 7704 +3
+ Misses 1143 1141 -2
+ Partials 412 411 -1
|
fuzzybinary
approved these changes
Sep 2, 2022
| @@ -62,11 +62,6 @@ class CrashFragment : | |||
| viewModel = ViewModelProviders.of(this).get(CrashViewModel::class.java) | |||
| } | |||
|
|
|||
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | |||
| super.onViewCreated(view, savedInstanceState) | |||
| triggerCrash() | |||
There was a problem hiding this comment.
Is this crash mechanism no longer needed?
There was a problem hiding this comment.
Not when the view is created, we have buttons in the sample app ui to trigger different crashes (JVM, native,…)
xgouchet
approved these changes
Sep 5, 2022
| @@ -62,11 +62,6 @@ class CrashFragment : | |||
| viewModel = ViewModelProviders.of(this).get(CrashViewModel::class.java) | |||
| } | |||
|
|
|||
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | |||
| super.onViewCreated(view, savedInstanceState) | |||
| triggerCrash() | |||
There was a problem hiding this comment.
Not when the view is created, we have buttons in the sample app ui to trigger different crashes (JVM, native,…)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change updates Cmake to
3.22.1to address the previous rollback done in #716.Review checklist (to be filled by reviewers)