Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2353: Report frustration count on views #1030

Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Sep 1, 2022

What does this PR do?

This change adds view.frustration.count data point, which is a total count of the all the frustrations happened in all the nested actions.

To support this I've changed EventType enum to the sealed class, so it is possible to send a payload on the data storage notification loopback.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner September 1, 2022 15:12
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #1030 (157e679) into develop (639d58e) will increase coverage by 0.02%.
The diff coverage is 82.22%.

@@             Coverage Diff             @@
##           develop    #1030      +/-   ##
===========================================
+ Coverage    83.08%   83.10%   +0.02%     
===========================================
  Files          272      272              
  Lines         9235     9248      +13     
  Branches      1471     1483      +12     
===========================================
+ Hits          7672     7685      +13     
+ Misses        1147     1146       -1     
- Partials       416      417       +1     
Impacted Files Coverage Δ
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.49% <73.68%> (-0.37%) ⬇️
...ndroid/rum/internal/domain/event/RumEventMapper.kt 94.00% <85.71%> (-1.83%) ⬇️
...tadog/android/rum/internal/monitor/StorageEvent.kt 85.71% <85.71%> (ø)
...tadog/android/rum/internal/domain/RumDataWriter.kt 85.71% <87.50%> (-2.75%) ⬇️
...g/android/rum/internal/domain/scope/RumRawEvent.kt 82.55% <100.00%> (+0.12%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 96.91% <100.00%> (+0.01%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 75.00% <0.00%> (-25.00%) ⬇️
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 82.61% <0.00%> (-4.35%) ⬇️
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 96.15% <0.00%> (-3.85%) ⬇️
...tadog/android/core/internal/net/CurlInterceptor.kt 80.95% <0.00%> (-2.38%) ⬇️
... and 5 more

@xgouchet xgouchet added the size-small This PR is small sized label Sep 1, 2022
@0xnm 0xnm merged commit 520d778 into develop Sep 2, 2022
@0xnm 0xnm deleted the nogorodnikov/rumm-2353/report-frustration-count-on-views branch September 2, 2022 07:10
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small This PR is small sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants