Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taps not recorded when your finger moves a little #1389

Closed
GetsEclectic opened this issue Apr 17, 2023 · 2 comments
Closed

Taps not recorded when your finger moves a little #1389

GetsEclectic opened this issue Apr 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@GetsEclectic
Copy link

Thanks for taking the time for reporting an issue!

Describe what happened
Include any error message or stack trace if available.

If you tap and move your finger slightly before releasing, it doesn't show up as a tap in RUM.

Steps to reproduce the issue:

Put your finger/cursor on a button, move 5-10px and then release. The UI will recognize this as a button press but it doesn't show up in RUM.

I believe this is because GesturesListener.onUp handles scrolls and swipes but not taps. It looks like the UI behavior is that if the down is on a button and the up is on the same button, it will be recognized as tapping the button.

You can tap down on a button, move off of the button, move back onto the button, and then release, and it will count as tapping the button.

If you tap down on a button, move off of the button, and then release, it will not count as tapping the button.

It is not uncommon that people move their finger slightly when pressing a button. It looks very strange in RUM as if they went to a new screen with no tap.

Describe what you expected:

I expect this to be recognized as a tap if the UI recognizes it as a tap.

Additional context
Android OS version: 14
Device Model: pixel 4 xl
Datadog SDK version: 1.17.1
Versions of any other relevant dependencies (OkHttp, …):
Proguard configuration:
Gradle Plugins:

@GetsEclectic GetsEclectic added the bug Something isn't working label Apr 17, 2023
@xgouchet
Copy link
Member

This is fixed by #1622 , which will be released soon.

@GetsEclectic
Copy link
Author

GetsEclectic commented Sep 19, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants