Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd-sdk-android-timber requires dd-sdk-android:1.2.1 #138

Closed
mduong opened this issue Feb 18, 2020 · 7 comments
Closed

dd-sdk-android-timber requires dd-sdk-android:1.2.1 #138

mduong opened this issue Feb 18, 2020 · 7 comments
Assignees
Labels
bug Something isn't working fixed
Milestone

Comments

@mduong
Copy link

mduong commented Feb 18, 2020

Thanks for taking the time for reporting an issue!

Describe what happened
Include any error message or stack trace if available.

In trying to include dd-sdk-android-timber as a dependency, resolution fails because it cannot find dd-sdk-android:1.2.1. Looking at the POM file for dd-sdk-android-timber, it appears that it requires 1.2.1 as a dependency (https://dl.bintray.com/datadog/datadog-maven/com/datadoghq/dd-sdk-android-timber/), but that does not exist. I believe it should be 1.2.0.

Error message:

ERROR: Failed to resolve: dd-sdk-android:dd-sdk-android:1.2.1

Steps to reproduce the issue:
Add this to your build.gradle and perform a Gradle sync:

repositories {
    maven { url “https://dl.bintray.com/datadog/datadog-maven" }
}

dependencies {
    implementation "com.datadoghq:dd-sdk-android:1.2.0"
    implementation "com.datadoghq:dd-sdk-android-timber:1.2.0"
}

Describe what you expected:
Expected Gradle dependency resolution to complete successfully.

Additional context

  • Android OS version:
  • Device Model:
  • Datadog SDK version:
  • Versions of any other relevant dependencies (OkHttp, …):
  • Proguard configuration:
  • Gradle Plugins:
@mduong mduong added the bug Something isn't working label Feb 18, 2020
@xgouchet
Copy link
Member

Indeed there's an issue in the published pom. We'll check that ASAP.

@xgouchet xgouchet self-assigned this Feb 19, 2020
@xgouchet xgouchet mentioned this issue Feb 19, 2020
3 tasks
@xgouchet
Copy link
Member

Thanks again for reporting this issue @mduong. It's now fixed :

  • We published a version 1.2.1 of the libraries (both dd-sdk-android and dd-sdk-android-timber);
  • We fixed our publishing script so that this issue doesn't happen anymore :)

@mduong
Copy link
Author

mduong commented Feb 19, 2020

Thanks @xgouchet. I think there may still be an issue. Upon further inspection of the dd-sdk-android-timber POM, I believe the groupId for dd-sdk-android should be com.datadoghq instead of dd-sdk-android.

@alparp27
Copy link

alparp27 commented Feb 19, 2020

I am also having the same issue.
ERROR: Failed to resolve: com.datadoghq:dd-sdk-android:1.2.0 with 1.2.1, 1.2.0 or +.

@rafaela-stockx
Copy link

rafaela-stockx commented Feb 21, 2020

Currently trying to use the latest version and seeing the same error behavior.
"com.datadoghq:dd-sdk-android:1.2.1"
"com.datadoghq:dd-sdk-android-timber:1.2.1"

NOTE : The 1.2.1 version gradle dependency work as expected if there is no need to pull the timber integration version.

@xgouchet
Copy link
Member

xgouchet commented Feb 26, 2020

Indeed there's was another issue, nicely spotted @rafaela-stockx
Should really be fixed in 1.2.2

@mduong
Copy link
Author

mduong commented Feb 27, 2020

Confirming fixed in 1.2.2.

@mduong mduong closed this as completed Feb 27, 2020
@xgouchet xgouchet added the fixed label May 10, 2021
@xgouchet xgouchet modified the milestones: 1.10.0, 1.2.2 May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

4 participants