Skip to content

Commit

Permalink
RUM-6035 Add the integration tests related with RumMonitor#addViewLoa…
Browse files Browse the repository at this point in the history 
…dingTime API
  • Loading branch information
@mariusc83
mariusc83 committed Sep 18, 2024
1 parent e70c3ea commit 2d4c7a4
Show file tree
Hide file tree
Showing 2 changed files with 230 additions and 0 deletions.
215 changes: 215 additions & 0 deletions ...ngle-fit/rum/src/test/kotlin/com/datadog/android/rum/integration/ManualTrackingRumTest.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package com.datadog.android.rum.integration

import com.datadog.android.api.feature.Feature
import com.datadog.android.core.stub.StubSDKCore
import com.datadog.android.rum.ExperimentalRumApi
import com.datadog.android.rum.GlobalRumMonitor
import com.datadog.android.rum.Rum
import com.datadog.android.rum.RumActionType
Expand All @@ -23,13 +24,15 @@ import com.datadog.tools.unit.annotations.TestConfigurationsProvider
import com.datadog.tools.unit.extensions.TestConfigurationExtension
import com.datadog.tools.unit.extensions.config.TestConfiguration
import fr.xgouchet.elmyr.Forge
import fr.xgouchet.elmyr.annotation.BoolForgery
import fr.xgouchet.elmyr.annotation.Forgery
import fr.xgouchet.elmyr.annotation.IntForgery
import fr.xgouchet.elmyr.annotation.LongForgery
import fr.xgouchet.elmyr.annotation.StringForgery
import fr.xgouchet.elmyr.junit5.ForgeConfiguration
import fr.xgouchet.elmyr.junit5.ForgeExtension
import org.assertj.core.api.Assertions.assertThat
import org.assertj.core.data.Offset
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.RepeatedTest
import org.junit.jupiter.api.extension.ExtendWith
Expand All @@ -38,6 +41,7 @@ import org.mockito.junit.jupiter.MockitoExtension
import org.mockito.junit.jupiter.MockitoSettings
import org.mockito.quality.Strictness
import java.net.URL
import java.util.concurrent.TimeUnit

@Extensions(
ExtendWith(MockitoExtension::class),
Expand Down Expand Up @@ -395,6 +399,217 @@ class ManualTrackingRumTest {

// endregion

// region AddViewLoading time

@OptIn(ExperimentalRumApi::class)
@RepeatedTest(16)
fun `M attach view loading time W addViewLoadingTime { active view available }`(
@StringForgery key: String,
@StringForgery name: String,
@BoolForgery overwrite: Boolean
) {
// Given
val rumMonitor = GlobalRumMonitor.get(stubSdkCore)
val startTime = System.nanoTime()
rumMonitor.startView(key, name, emptyMap())

// When
val endTime = System.nanoTime()
val expectedViewLoadingTime = endTime - startTime
rumMonitor.addViewLoadingTime(overwrite)

// Then
val eventsWritten = stubSdkCore.eventsWritten(Feature.RUM_FEATURE_NAME)
StubEventsAssert.assertThat(eventsWritten)
.hasSize(2)
.hasRumEvent(index = 0) {
// Initial view
hasService(stubSdkCore.getDatadogContext().service)
hasApplicationId(fakeApplicationId)
hasSessionType("user")
hasSource("android")
hasType("view")
hasViewUrl(key)
hasViewName(name)
hasActionCount(0)
}
.hasRumEvent(index = 1) {
// view updated with loading time
hasService(stubSdkCore.getDatadogContext().service)
hasApplicationId(fakeApplicationId)
hasSessionType("user")
hasSource("android")
hasType("view")
hasViewUrl(key)
hasViewName(name)
hasViewLoadingTime(
expectedViewLoadingTime,
offset = Offset.offset(TimeUnit.MILLISECONDS.toNanos(5))
)
}
}

@OptIn(ExperimentalRumApi::class)
@RepeatedTest(16)
fun `M not attach view loading time W addViewLoadingTime { view was stopped }`(
@StringForgery key: String,
@StringForgery name: String,
@BoolForgery overwrite: Boolean
) {
// Given
val rumMonitor = GlobalRumMonitor.get(stubSdkCore)
rumMonitor.startView(key, name, emptyMap())
rumMonitor.stopView(key, emptyMap())

// When
rumMonitor.addViewLoadingTime(overwrite)

// Then
val eventsWritten = stubSdkCore.eventsWritten(Feature.RUM_FEATURE_NAME)
StubEventsAssert.assertThat(eventsWritten)
.hasSize(2)
.hasRumEvent(index = 0) {
// Initial view
hasService(stubSdkCore.getDatadogContext().service)
hasApplicationId(fakeApplicationId)
hasSessionType("user")
hasSource("android")
hasType("view")
hasViewUrl(key)
hasViewName(name)
hasActionCount(0)
}
.hasRumEvent(index = 1) {
// view stopped
hasService(stubSdkCore.getDatadogContext().service)
hasApplicationId(fakeApplicationId)
hasSessionType("user")
hasSource("android")
hasType("view")
hasViewUrl(key)
hasViewName(name)
doesNotHaveViewLoadingTime()
}
}

@OptIn(ExperimentalRumApi::class)
@RepeatedTest(16)
fun `M renew view loading time W addViewLoadingTime { loading time was already added, overwrite is true }`(
@StringForgery key: String,
@StringForgery name: String,
@BoolForgery overwrite: Boolean
) {
// Given
val rumMonitor = GlobalRumMonitor.get(stubSdkCore)
val startTime = System.nanoTime()
rumMonitor.startView(key, name, emptyMap())
val intermediateTime = System.nanoTime()
rumMonitor.addViewLoadingTime(overwrite)

// When
Thread.sleep(100)
val endTime = System.nanoTime()
rumMonitor.addViewLoadingTime(true)

// Then
val expectedFirstViewLoadingTime = intermediateTime - startTime
val expectedSecondViewLoadingTime = endTime - startTime
val eventsWritten = stubSdkCore.eventsWritten(Feature.RUM_FEATURE_NAME)
StubEventsAssert.assertThat(eventsWritten)
.hasSize(3)
.hasRumEvent(index = 0) {
// Initial view
hasService(stubSdkCore.getDatadogContext().service)
hasApplicationId(fakeApplicationId)
hasSessionType("user")
hasSource("android")
hasType("view")
hasViewUrl(key)
hasViewName(name)
hasActionCount(0)
}
.hasRumEvent(index = 1) {
// first view loading time
hasService(stubSdkCore.getDatadogContext().service)
hasApplicationId(fakeApplicationId)
hasSessionType("user")
hasSource("android")
hasType("view")
hasViewUrl(key)
hasViewName(name)
hasViewLoadingTime(
expectedFirstViewLoadingTime,
offset = Offset.offset(TimeUnit.MILLISECONDS.toNanos(5))
)
}
.hasRumEvent(index = 2) {
// second view loading time
hasService(stubSdkCore.getDatadogContext().service)
hasApplicationId(fakeApplicationId)
hasSessionType("user")
hasSource("android")
hasType("view")
hasViewUrl(key)
hasViewName(name)
hasViewLoadingTime(
expectedSecondViewLoadingTime,
offset = Offset.offset(TimeUnit.MILLISECONDS.toNanos(5))
)
}
}

@OptIn(ExperimentalRumApi::class)
@RepeatedTest(16)
fun `M not renew view loading time W addViewLoadingTime { loading time was already added, overwrite is false }`(
@StringForgery key: String,
@StringForgery name: String,
@BoolForgery overwrite: Boolean
) {
// Given
val rumMonitor = GlobalRumMonitor.get(stubSdkCore)
val startTime = System.nanoTime()
rumMonitor.startView(key, name, emptyMap())
val intermediateTime = System.nanoTime()
rumMonitor.addViewLoadingTime(overwrite)

// When
Thread.sleep(100)
rumMonitor.addViewLoadingTime(false)

// Then
val expectedViewLoadingTime = intermediateTime - startTime
val eventsWritten = stubSdkCore.eventsWritten(Feature.RUM_FEATURE_NAME)
StubEventsAssert.assertThat(eventsWritten)
.hasSize(2)
.hasRumEvent(index = 0) {
// Initial view
hasService(stubSdkCore.getDatadogContext().service)
hasApplicationId(fakeApplicationId)
hasSessionType("user")
hasSource("android")
hasType("view")
hasViewUrl(key)
hasViewName(name)
hasActionCount(0)
}
.hasRumEvent(index = 1) {
// first view loading time
hasService(stubSdkCore.getDatadogContext().service)
hasApplicationId(fakeApplicationId)
hasSessionType("user")
hasSource("android")
hasType("view")
hasViewUrl(key)
hasViewName(name)
hasViewLoadingTime(
expectedViewLoadingTime,
offset = Offset.offset(TimeUnit.MILLISECONDS.toNanos(5))
)
}
}

// endregion

companion object {
private val mainLooper = MainLooperTestConfiguration()

Expand Down
15 changes: 15 additions & 0 deletions ...t/rum/src/test/kotlin/com/datadog/android/rum/integration/tests/assertj/RumEventAssert.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package com.datadog.android.rum.integration.tests.assertj

import com.datadog.tools.unit.assertj.JsonObjectAssert
import com.google.gson.JsonObject
import org.assertj.core.data.Offset

class RumEventAssert(actual: JsonObject) :
JsonObjectAssert(actual, true) {
Expand Down Expand Up @@ -123,6 +124,20 @@ class RumEventAssert(actual: JsonObject) :

// endregion

// region view loading time

fun hasViewLoadingTime(time: Long, offset: Offset<Long>): RumEventAssert {
hasField("view.loading_time", time, offset = offset)
return this
}

fun doesNotHaveViewLoadingTime(): RumEventAssert {
doesNotHaveField("view.loading_time")
return this
}

// endregion

companion object {
fun assertThat(actual: JsonObject): RumEventAssert {
return RumEventAssert(actual)
Expand Down

0 comments on commit 2d4c7a4

Please sign in to comment.