Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap retry to five minutes rc polling #246

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

estringana
Copy link
Collaborator

Description

Cap retry to five minutes rc polling

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@codecov-commenter
Copy link

Codecov Report

Merging #246 (bdd2d8e) into master (52a5661) will decrease coverage by 10.12%.
The diff coverage is 57.14%.

@@             Coverage Diff             @@
##           master     #246       +/-   ##
===========================================
- Coverage   63.66%   53.54%   -10.12%     
===========================================
  Files          90       65       -25     
  Lines        5603     2385     -3218     
  Branches     1775     1060      -715     
===========================================
- Hits         3567     1277     -2290     
+ Misses        971      418      -553     
+ Partials     1065      690      -375     
Flag Coverage Δ
extension ?
helper 53.54% <57.14%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helper/remote_config/client_handler.hpp 100.00% <ø> (ø)
src/helper/remote_config/client_handler.cpp 70.88% <57.14%> (+1.55%) ⬆️

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@estringana estringana force-pushed the estringana/cap-retry-to-five-minutes-3 branch from bdd2d8e to 1be135e Compare April 17, 2023 10:40
@estringana estringana marked this pull request as ready for review April 17, 2023 12:48
@estringana estringana requested a review from Anilm3 April 17, 2023 12:48
Copy link
Collaborator

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estringana estringana merged commit 3ad61e0 into master Apr 18, 2023
@estringana estringana deleted the estringana/cap-retry-to-five-minutes-3 branch April 18, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants