Add init / commit stage to listeners #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
===========================================
- Coverage 64.08% 53.21% -10.87%
===========================================
Files 82 58 -24
Lines 5363 2191 -3172
Branches 1689 983 -706
===========================================
- Hits 3437 1166 -2271
+ Misses 918 379 -539
+ Partials 1008 646 -362
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
… 0 expiration value
estringana
reviewed
Mar 1, 2023
| @@ -37,7 +37,9 @@ struct client { | |||
| void set_capabilities(const std::vector<capabilities_e> &cs) | |||
| { | |||
| for (const auto &capability : cs) { | |||
| capabilities |= static_cast<uint16_t>(capability); | |||
| capabilities |= | |||
estringana
reviewed
Mar 1, 2023
|
|
||
| auto rule = rules_data.find(id->value.GetString()); | ||
| if (rule == rules_data.end()) { // New rule | ||
| if (type != "data_with_expiration" && type != "ip_with_expiration") { |
There was a problem hiding this comment.
I am missing a test for this type filtering
There was a problem hiding this comment.
Since I'm working on a PR derived from this one I'll add the test on that PR
estringana
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
Motivation
Additional Notes
Describe how to test your changes
Readiness checklist
Release checklist