Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade WAF 1.8.2 and Ruleset 1.5.1 #202

Merged
merged 9 commits into from
Feb 23, 2023

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Feb 21, 2023

Description

  • Updated WAF to 1.8.2
  • Updated Ruleset to 1.5.1
  • Removed engine::update_rule_data
  • Removed subscriber::update_rule_data
  • Added subscriber::update which returns new subscriber instance
  • Added engine::update function which atomically replaces the subscribers and actions

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #202 (b333f6f) into master (75177a1) will decrease coverage by 0.03%.
The diff coverage is 43.90%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   64.76%   64.74%   -0.03%     
==========================================
  Files          81       81              
  Lines        5236     5247      +11     
  Branches     1620     1615       -5     
==========================================
+ Hits         3391     3397       +6     
- Misses        885      895      +10     
+ Partials      960      955       -5     
Flag Coverage Δ
extension 71.32% <ø> (ø)
helper 54.78% <43.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helper/subscriber/base.hpp 100.00% <ø> (ø)
src/helper/subscriber/waf.hpp 33.33% <0.00%> (-66.67%) ⬇️
src/helper/subscriber/waf.cpp 54.69% <39.39%> (-0.86%) ⬇️
src/helper/engine.cpp 53.17% <50.00%> (+0.65%) ⬆️
src/helper/engine.hpp 81.81% <100.00%> (ø)
src/helper/remote_config/asm_data_listener.cpp 58.88% <100.00%> (+1.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

estringana
estringana previously approved these changes Feb 21, 2023
@Anilm3 Anilm3 requested a review from estringana February 21, 2023 17:01
@Anilm3 Anilm3 marked this pull request as ready for review February 22, 2023 15:41
@Anilm3 Anilm3 dismissed estringana’s stale review February 22, 2023 15:47

I've made many changes since the last review.

@Anilm3 Anilm3 merged commit 166c061 into master Feb 23, 2023
@Anilm3 Anilm3 deleted the anilm3/upgrade-waf.1.8.2-and-ruleset-1.5.1 branch February 23, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants