-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade WAF 1.8.2 and Ruleset 1.5.1 #202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 64.76% 64.74% -0.03%
==========================================
Files 81 81
Lines 5236 5247 +11
Branches 1620 1615 -5
==========================================
+ Hits 3391 3397 +6
- Misses 885 895 +10
+ Partials 960 955 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…om:DataDog/dd-appsec-php into anilm3/upgrade-waf.1.8.2-and-ruleset-1.5.1
estringana
previously approved these changes
Feb 21, 2023
I've made many changes since the last review.
estringana
reviewed
Feb 23, 2023
estringana
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
engine::update_rule_data
subscriber::update_rule_data
subscriber::update
which returns new subscriber instanceengine::update
function which atomically replaces the subscribers and actionsMotivation
Additional Notes
Describe how to test your changes
Readiness checklist
Release checklist