-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create config sync request #164
Create config sync request #164
Conversation
4fd6ce9
to
dd4cbf0
Compare
dd4cbf0
to
369468a
Compare
Codecov Report
@@ Coverage Diff @@
## develop/remote-config #164 +/- ##
=========================================================
- Coverage 63.40% 63.23% -0.18%
=========================================================
Files 76 76
Lines 4495 4561 +66
Branches 1359 1391 +32
=========================================================
+ Hits 2850 2884 +34
- Misses 834 842 +8
- Partials 811 835 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
27492ee
to
9640d82
Compare
4f328d3
to
923a803
Compare
5df2924
to
45d630f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a preliminary PR to introduce multiple responses it seems fine although I think it's quite far from a final version of this concept as we'd ideally want the message queue to be in an abstraction, perhaps in the broker, then flushed by the client somehow.
Description
This PR:
config_sync
resquest/responseconfig_features
responseMotivation
Additional Notes
Describe how to test your changes
Readiness checklist
Release checklist