Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create config sync request #164

Merged

Conversation

estringana
Copy link
Collaborator

@estringana estringana commented Nov 29, 2022

Description

This PR:

  • Adds config_sync resquest/response
  • Adds config_features response
  • Make responses to be an array of messages
  • Makes each message to contain the name of the message on the first field of the message array

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@estringana estringana changed the base branch from master to develop/remote-config November 30, 2022 09:14
@estringana estringana force-pushed the estringana/create-config-sync-request branch from 4fd6ce9 to dd4cbf0 Compare November 30, 2022 09:15
@estringana estringana force-pushed the estringana/create-config-sync-request branch from dd4cbf0 to 369468a Compare December 7, 2022 12:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Merging #164 (de1f806) into develop/remote-config (01e3cf8) will decrease coverage by 0.17%.
The diff coverage is 56.38%.

@@                    Coverage Diff                    @@
##           develop/remote-config     #164      +/-   ##
=========================================================
- Coverage                  63.40%   63.23%   -0.18%     
=========================================================
  Files                         76       76              
  Lines                       4495     4561      +66     
  Branches                    1359     1391      +32     
=========================================================
+ Hits                        2850     2884      +34     
- Misses                       834      842       +8     
- Partials                     811      835      +24     
Flag Coverage Δ
extension 69.22% <60.00%> (-0.06%) ⬇️
helper 54.03% <55.95%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helper/network/broker.hpp 100.00% <ø> (ø)
src/helper/client.cpp 44.55% <42.85%> (-3.24%) ⬇️
src/extension/commands_helpers.c 66.97% <60.00%> (-0.66%) ⬇️
src/helper/network/broker.cpp 43.47% <62.50%> (+3.47%) ⬆️
src/helper/network/proto.hpp 72.22% <87.50%> (+4.72%) ⬆️
src/helper/client.hpp 70.00% <100.00%> (+7.50%) ⬆️
src/helper/service.hpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@estringana estringana force-pushed the estringana/create-config-sync-request branch from 27492ee to 9640d82 Compare December 13, 2022 12:34
@estringana estringana force-pushed the estringana/create-config-sync-request branch from 4f328d3 to 923a803 Compare December 14, 2022 11:50
@estringana estringana force-pushed the estringana/create-config-sync-request branch from 5df2924 to 45d630f Compare December 14, 2022 14:57
@estringana estringana marked this pull request as ready for review December 15, 2022 09:12
@estringana estringana requested a review from Anilm3 December 15, 2022 09:12
Anilm3
Anilm3 previously approved these changes Dec 16, 2022
Copy link
Collaborator

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a preliminary PR to introduce multiple responses it seems fine although I think it's quite far from a final version of this concept as we'd ideally want the message queue to be in an abstraction, perhaps in the broker, then flushed by the client somehow.

src/extension/commands_helpers.c Show resolved Hide resolved
src/helper/client.cpp Outdated Show resolved Hide resolved
src/helper/client.cpp Outdated Show resolved Hide resolved
src/helper/client.cpp Show resolved Hide resolved
@estringana estringana merged commit dacfcb0 into develop/remote-config Dec 19, 2022
@estringana estringana deleted the estringana/create-config-sync-request branch December 19, 2022 11:56
Anilm3 pushed a commit that referenced this pull request Jan 19, 2023
Anilm3 pushed a commit that referenced this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants