Handle errors on request_shutdown #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estringana
previously approved these changes
Sep 23, 2022
estringana
approved these changes
Sep 23, 2022
estringana
reviewed
Sep 23, 2022
| UNUSED(dd_request_shutdown(conn)); | ||
| int res = dd_request_shutdown(conn); | ||
| if (res == dd_network) { | ||
| mlog_g(dd_log_info, |
There was a problem hiding this comment.
Should this be error instead of info?
There was a problem hiding this comment.
There's other error logs before getting here so these are fine as info.
estringana
reviewed
Sep 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 63.17% 69.19% +6.01%
==========================================
Files 63 21 -42
Lines 4253 2756 -1497
Branches 1286 632 -654
==========================================
- Hits 2687 1907 -780
+ Misses 815 515 -300
+ Partials 751 334 -417
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Anilm3
added a commit
that referenced
this pull request
Sep 23, 2022
estringana
pushed a commit
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
request_shutdownwith side-effects was introduced, the appropriateRSHUTDOWNcode was not updated to handle errors. This simply requires closing the connection when a network error is received and log a message otherwise.Motivation
Additional Notes
Describe how to test your changes
Readiness checklist
Release checklist