Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all integration requests if session token is none #141

Merged
merged 4 commits into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ddapm_test_agent/agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -386,11 +386,14 @@ async def _tracestats_by_session(self, token: Optional[str]) -> List[v06StatsPay
return stats

async def _integration_requests_by_session(
self, token: Optional[str], include_sent_integrations: Optional[bool] = False
self,
token: Optional[str],
include_sent_integrations: Optional[bool] = False,
) -> List[Request]:
"""Get all requests with an associated tested Integration."""
integration_requests: List[Request] = []
for req in self._requests_by_session(token):
requests = self._requests if token is None else self._requests_by_session(token)
for req in requests:
# see if the request was to update with a newly tested integration
if req.match_info.handler == self.handle_put_tested_integrations:
if "integration" not in req:
Expand Down Expand Up @@ -520,11 +523,10 @@ async def handle_get_tested_integrations(self, request: Request) -> web.Response
aggregated_text = ""
seen_integrations = set()
req_headers = {}
token = _session_token(request)

# get all requests associated with an integration
reqs = await self._integration_requests_by_session(
token=_session_token(request), include_sent_integrations=True
)
reqs = await self._integration_requests_by_session(token=token, include_sent_integrations=True)
for req in reqs:
integration = req["integration"]

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
Add fix for getting tested integrations when multiple session tokens are used. When no session token is included for a [GET] request to
'/test/integrations/tested_versions', all tested integrations are returned now.
Kyle-Verhoog marked this conversation as resolved.
Show resolved Hide resolved
Loading