Skip to content

Commit

Permalink
add release note
Browse files Browse the repository at this point in the history
  • Loading branch information
wconti27 committed Jul 12, 2023
1 parent d113ba8 commit e580281
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ddapm_test_agent/trace_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,9 @@ def check(self, trace: List[Span], dd_config_env: Dict[str, str]) -> None:
# check for special case where span is of type web and has context as service
if "servlet.context" in meta.keys() or trace_context:
trace_context = (
trace_context if trace_context is not None else meta.get("servlet.context", "").replace("/", "")
trace_context
if trace_context is not None
else meta.get("servlet.context", "").replace("/", "")
)
if service != trace_context:
self.fail(
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
features:
- |
Adds two new Trace Checks for service naming and peer service. `trace_dd_service` check ensures that handled traces
have a correctly configured service name according to the trace's Span Attribute Schema Version. `trace_peer_service`
ensures the that the correct `peer.service` value is set for spans according to the supplied span precursors.

0 comments on commit e580281

Please sign in to comment.