Add check for php-fpm status #630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| raise Exception("No metrics were fetched for this instance. Make sure that %s is the proper url." % instance['php_status_url']) | ||
|
|
||
| @staticmethod | ||
| def parse_agent_config(agentConfig): |
There was a problem hiding this comment.
Implementing this method is not needed here.
This method is intended for backward compatibilty purposes that is not required here.
|
Thanks for the comments remh. To be fair these are my very first steps in python ;-) |
|
👍 |
| # Send metric as a rate, if applicable | ||
| if metric in self.RATES: | ||
| metric_name = self.RATES[metric] | ||
| self.rate(metric_name, value, tags=tags) |
There was a problem hiding this comment.
This should be self.GAUGES and self.gauge. Not self.RATES/self.rate
…-agent into feature/php_check # By Remi Hakim (391) and others # Via Remi Hakim (72) and others * 'feature/php_check' of https://github.com/arosenhagen/dd-agent: (574 commits) fix logging Bump source install to 4.1.0 Fix environment variable in source install supervisor Revert "Bump source install to 4.1.0" Bump source install to 4.1.0 Fix windows gui where it could crash in some very rare cases Fix windows test Fix network check tests Revert "Fix network check tests" Fix network check tests Properly get the postgresql connection and add support for older versions of psycopg2 Do not fail the info page if we can't get the ntp offset Fix TypeError('NoneType') if tags is not set in configuration Add the ability to add tags to an elasticsearch instance Only supports one instance for network check Add the possibility to launch the collection of metrics in the console directly from the agent code Point to doc in jmx checks configuration examples Properly read database name in yaml config for postgres Fix typo, and add precision to logged compression ratio Fix forwarder logging ...
* upstream/master: (539 commits) Update haproxy yaml comments Update cassandra fix gohai command on non windows hosts info instead of warn when gohai not found Add gohai metadata to payload when needed Get snmpd conf file from a branch that still exists Small wording changes after Conor's comments Rename tags "check:" instead of "service:" Reflect the default argument in conf example Remove unnecessary bundled dependencies (boto, yaml, httplib2). They'll be installed with the self contained agent Source install might still run the agent with python2.6 Update CHANGELOG.md 4.4.0 is out Fix test that was not updated. Add support for optional message with service checks. Update CHANGELOG.md SNMP Checks| Resurrect wrongly deleted SNMP_checks GCE tags should be None instead of an empty list Log something when instance metadata collection is disabled Update change log ...
…php_check * commit '029ba151fb960f8235d403aa6454a8a70c02cd15': (56 commits) Send the ntp offset as a metric Update changelog Fix whitespaces Do not count dogstatsd in the running processes at it can be disabled Update changelog Update changelog Update changelog Update Changelog Update CHANGELOG.md Update changelog Expvar| Make aliasing consistent with jmxfetch split packets on any line ending using built-in method Update metric with additional_metrics place tests in Rakefile in 'test' namespace add cleanup task to Rakefile for generated files Update elasticsearch metrics according to different ES versions Expvar| Use a more informative defaultname Add function to format the metric names Fix nginx test Add some more test to count_per_status ...
include php_ping check;
|
@zhaidri can you take a look at the code? I know people who'll want to take a look and test it out. |
|
bump |
|
Closing this one, will merge #1441 rebased version with some modifications. Thanks again @arosenhagen for your contribution and for other people following following this PR please take a look at the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AgentCheck for PHP-FPM Status similar to nginx status