Directory check #581
Merged
Directory check #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks for this check Brett, I've wanted to do this for a while but never got around to it. One small thing before merging, we try to stay compatible with python 2.4, do you think you can switch the .format() string formatting to %-style formatting? |
|
@clofresh no problem, done. |
|
Cool! One more small recommendation. Can we prefix the dirs with |
|
@clutchski what do you mean? prefix the metric names with |
|
Yes, exactly. Sorry that wasn't super clear ;) |
|
@clutchski no problem, just wanted to make sure I got it right :) |
|
Merging. Thanks @brettlangdon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the most useful check for you guys to have, but we intend to use it for alerts.
basically we have directories which have log files that are rotates every so often and then they get uploaded to s3 and deleted. We want to use a check like this to setup alerts for when the age of a file is too old or when there are more files than expected in a directory.