-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event support in dogstatsd #532
Conversation
@LotharSee works as-is with python 2.4? |
Not tested yet, I will. |
Maybe a dumb question, but is there a max size of these packets? Can you write an event that's too big to fit into one packet? |
Yeah the maximum size is 8K. I will add a limit in the dogstatsd client. |
@LotharSee What's the status of this? Should it go in 3.8.0 (the release I'm building this week)? |
I prefer to keep it away form this release. |
meta = metadata[title_length+text_length+1:] | ||
for m in meta.split('|')[1:]: | ||
if m[0] == u't': | ||
event['alert_type'] = m[2:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to avoid hard coding these keys and just pass along keys to the server which would do the validation? Having these on the client side makes it difficult to change them.
This PR allow DogStatsD to send events.
The event syntax is like this:
_e{title_length,body_length}:title|body|p:priority|k:aggregation_key|t:alert_type|s:source_type_name|d:date_happened|h:hostname|#tag1,tag2
Some details:
Exemple:
_e{8,21}My title:The world is burning!|h:my_computer|#danger,on_fire
I need some review about this protocol modification before adding it everywhere (documentation, librairies, dogstatsd client in the agent, ...).
One last thing: for now, events are sent one by one. I have two solutions to fix it:
What's the best?