[mongodb] Add metrics for fsyncLocked-ness, replset votes and vote fraction

checks.d/mongo.py

@@ -72,6 +72,7 @@ class MongoDb(AgentCheck):
         "cursors.totalOpen": GAUGE,
         "extra_info.heap_usage_bytes": RATE,
         "extra_info.page_faults": RATE,
+        "fsyncLocked": GAUGE,
         "globalLock.activeClients.readers": GAUGE,
         "globalLock.activeClients.total": GAUGE,
         "globalLock.activeClients.writers": GAUGE,
@@ -156,6 +157,8 @@ class MongoDb(AgentCheck):
         "replSet.health": GAUGE,
         "replSet.replicationLag": GAUGE,
         "replSet.state": GAUGE,
+        "replSet.votes": GAUGE,
+        "replSet.voteFraction": GAUGE,
         "stats.avgObjSize": GAUGE,
         "stats.collections": GAUGE,
         "stats.dataSize": GAUGE,
@@ -728,6 +731,9 @@ def total_seconds(td):
         if status['ok'] == 0:
             raise Exception(status['errmsg'].__str__())
 
+        ops = db['$cmd.sys.inprog'].find_one()
+        status['fsyncLocked'] = 1 if ops.get('fsyncLock') else 0
+
         status['stats'] = db.command('dbstats')
         dbstats = {}
         dbstats[db_name] = {'stats': status['stats']}
@@ -789,6 +795,16 @@ def total_seconds(td):
                     data['health'] = current['health']
 
                 data['state'] = replSet['myState']
+
+                if current is not None:
+                    total = 0.0
+                    cfg = cli['local']['system.replset'].find_one()
+                    for member in cfg.get('members'):
+                        total += member.get('votes', 1)
+                        if member['_id'] == current['_id']:
+                            data['votes'] = member.get('votes', 1)
+                    data['voteFraction'] = data['votes'] / total
+
                 status['replSet'] = data
 
                 # Submit events

ci/common.rb

@@ -51,6 +51,7 @@ def travis_pr?
   'sysstat' => 'system',
   'elastic' => 'elasticsearch',
   'gearmand' => 'gearman',
+  'mongo' => 'mongodb',
   'mcache' => 'memcache',
   'php_fpm' => 'phpfpm',
   'redisdb' => 'redis',

tests/checks/integration/test_mongo.py

@@ -1,7 +1,6 @@
 # stdlib
 from types import ListType
 import time
-import unittest
 
 # 3p
 from mock import Mock
@@ -153,8 +152,12 @@ def test_state_translation(self):
         unknown_desc = self.check.get_state_description(500)
         self.assertTrue(unknown_desc.find('500') != -1)
 
+
 @attr(requires='mongo')
-class TestMongo(unittest.TestCase):
+class TestMongo(AgentCheckTest):
+
+    CHECK_NAME = 'mongo'
+
     def setUp(self):
         server = "mongodb://localhost:%s/test" % PORT1
         cli = pymongo.mongo_client.MongoClient(
@@ -314,3 +317,27 @@ def testMongoOldConfig(self):
             metric_name = m[0]
             if metric_name in metric_val_checks:
                 self.assertTrue(metric_val_checks[metric_name](m[2]))
+
+    def testMongoFsyncLock(self):
+        server = "mongodb://localhost:%s/test" % PORT1
+        cli = pymongo.mongo_client.MongoClient(
+            server,
+            socketTimeoutMS=30000,
+            read_preference=pymongo.ReadPreference.PRIMARY_PREFERRED,)
+
+        try:
+            cli.fsync(lock=True)
+
+            # Run the check
+            config = {
+                'instances': [
+                    {'server': server}
+                ]
+            }
+            self.run_check(config)
+
+            # Assert
+            self.assertMetric("mongodb.fsynclocked", 1, count=1)
+
+        finally:
+            cli.unlock()