Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongo] Add metrics for fsyncLocked-ness, replset votes and vote fraction #2952

Closed
wants to merge 2 commits into from
Closed

Conversation

ebroder
Copy link
Contributor

@ebroder ebroder commented Oct 25, 2016

What does this PR do?

This introduces 3 new metrics:

  • fsyncLocked: which is 1 if the mongod is fsynclocked and 0 if not
  • replSet.votes: which is the number of votes assigned to a node (on 2.6 or newer this will always be 0 or 1)
  • replSet.voteFraction: the fraction of votes in the replset assigned to this node

Motivation

These metrics are part of our monitoring for mongo node health. We alert on nodes being fsyncLocked for an extended period of time (since it usually indicates forgotten maintenance), and on voteFraction-grouped-by-AZ being > 0.5, since that indicates that loss of an AZ would break quorum.

These are useful for validating replset configuration
(e.g. `sum:mongodb.replSet.voteFraction{} by
{mongo_replset,availability-zone}`)
@cory-stripe
Copy link
Contributor

Hey @olivielpeau, any chance we can get that 5.10 tag on this one? 😸

@yannmh
Copy link
Member

yannmh commented Oct 30, 2016

Thanks @ebroder !

I moved the MongoDB fsyncLock metric test to the AgentCheckTest class suite, and opened a new PR with your change: #2975. Let's move to this thread.

@yannmh yannmh closed this Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants