Enabled regex testing for content_match #1326
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a quick change to Ryan's http_check.py revisions that enable regex testing for content_match. This makes content_match more flexible in accommodating situations where a simple if ... in ... match would be insufficient.
Consider this real-life example of content being tested:
If we want to test for that first
"status":"UP"
, we need to use a regex because that string is not unique within the content string:The one gotcha with regex in content_match is special metacharacters like "?". I considered creating a content_match_re for regex matching but decided that it would be cleaner to just document in the example YAML the need to escape these characters.