Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop packaging network.yaml #620

Closed
elijahandrews opened this issue Aug 20, 2013 · 0 comments · Fixed by #1433
Closed

Stop packaging network.yaml #620

elijahandrews opened this issue Aug 20, 2013 · 0 comments · Fixed by #1433
Labels
packaging wontfix
Milestone
Future

Comments

@elijahandrews
Copy link
Contributor

#615 added the ability to configure excluded interfaces in network.yaml. Unfortunately, we package this file right now (instead of including network.yaml.example like we do for other checks), and we don't consider it a configuration file, so when a user updates this file will be overwritten. We should:

  1. Define default behaviour for the network check and have it run regardless of whether network.yaml is present. If network.yaml is present, the file will override the check's default behaviour.
  2. Stop packaging network.yaml and start packaging an example configuration in network.yaml.example.
@elijahandrews elijahandrews mentioned this issue Aug 20, 2013
Merged
@remh remh modified the milestones: 4.3.x, 4.2.x Mar 7, 2014
@remh remh modified the milestones: 5.1.0, 4.3.x May 8, 2014
@remh remh modified the milestones: 5.2.0, 5.1.0 Sep 26, 2014
@remh remh added the wontfix label Nov 26, 2014
@remh remh modified the milestones: Future, 5.2.0 Nov 26, 2014
remh added a commit that referenced this issue Mar 16, 2015
@remh
Enable ntp check by default
c7cb52d 
Also:

* Add a better way to have checks enabled by default
* Fix #620
* Ensure that we cast exception as string (otherwise pickle can fail
when persisting the collector status)
@remh remh mentioned this issue Mar 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
packaging wontfix
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Enable ntp check by default DataDog/dd-agent
2 participants
@elijahandrews @remh