[Core] Proxy, fix the way we set the no proxy environment setting #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remh
force-pushed
the
remh/fix_no_proxy
branch
3 times, most recently
from
485ea79 to
68af21f
Compare
|
Looks like this one is GTG. Tests are passing despite what the travis -> github integration says. |
| proxy_settings = {} | ||
|
|
||
| # First we read the proxy configuration from datadog.conf | ||
| proxy_host = agentConfig.get('proxy_host', None) |
There was a problem hiding this comment.
.get(_, None) from you @remh I am surprised :)
There was a problem hiding this comment.
ah yeah, i copy pasted the old code around, will fix. Thanks
|
Except for the few nitpicks, LGTM. Thanks for isolating this in a new ad hoc module. |
Fix #1594 Also: * simplify the proxy parsing * Move the code in a new utils module
remh
pushed a commit
that referenced
this pull request
Jun 2, 2015
[Core] Proxy, fix the way we set the no proxy environment setting
|
Changes Unknown when pulling 1c7d441 on remh/fix_no_proxy into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1594
Also: