Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Hardcoded no_proxy setting causes problems for EC2 metadata #1594

Closed
mikael-lindstrom opened this issue May 5, 2015 · 1 comment · Fixed by #1650
Closed

[Core] Hardcoded no_proxy setting causes problems for EC2 metadata #1594

mikael-lindstrom opened this issue May 5, 2015 · 1 comment · Fixed by #1650
Labels
bugfix core
Milestone
5.4.0

Comments

@mikael-lindstrom
Copy link

Following this pull request: #1518
no_proxy is now hardcoded to 127.0.0.1,localhost in dogstatsd.py and emitter.py

Since this is set in the environment it affects fetching of EC2 metadata on AWS as that is fetched from 169.254.169.254. If http_proxy is set, these requests will be sent through the proxy and return incorrect metadata.

This should be changed to respect addresses set in no_proxy and only append 127.0.0.1,localhost if they are missing.
@LeoCavaille
Copy link
Member

👍 thanks for reporting.

@LeoCavaille LeoCavaille added this to the 5.4.0 milestone May 7, 2015
remh added a commit that referenced this issue May 29, 2015
@remh
[Core] Proxy, fix the way we set the no proxy environment setting
9324caa 
Fix #1594

Also:
* simplify the proxy parsing
* Move the code in a new utils module
@remh remh mentioned this issue May 29, 2015
Merged
remh added a commit that referenced this issue Jun 1, 2015
@remh
[Core] Proxy, fix the way we set the no proxy environment setting
dd6e3e2 
Fix #1594

Also:
* simplify the proxy parsing
* Move the code in a new utils module
remh added a commit that referenced this issue Jun 1, 2015
@remh
[Core] Proxy, fix the way we set the no proxy environment setting
95f1768 
Fix #1594

Also:
* simplify the proxy parsing
* Move the code in a new utils module
remh added a commit that referenced this issue Jun 1, 2015
@remh
[Core] Proxy, fix the way we set the no proxy environment setting
68af21f 
Fix #1594

Also:
* simplify the proxy parsing
* Move the code in a new utils module
remh added a commit that referenced this issue Jun 2, 2015
@remh
[Core] Proxy, fix the way we set the no proxy environment setting
3c939d1 
Fix #1594

Also:
* simplify the proxy parsing
* Move the code in a new utils module
remh added a commit that referenced this issue Jun 2, 2015
@remh
[Core] Proxy, fix the way we set the no proxy environment setting
1c7d441 
Fix #1594

Also:
* simplify the proxy parsing
* Move the code in a new utils module
@remh remh closed this as completed in #1650 Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugfix core
Projects
None yet
Milestone
5.4.0
Development

Successfully merging a pull request may close this issue.

[Core] Proxy, fix the way we set the no proxy environment setting DataDog/dd-agent
2 participants
@LeoCavaille @mikael-lindstrom