Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fix on line 112 of timeboard,py pull_all command #84

Closed
wants to merge 3 commits into from

Conversation

jhotta
Copy link
Contributor

@jhotta jhotta commented Sep 5, 2015

No description provided.

@@ -109,7 +109,7 @@ def _title_to_filename(title):
return no_punct.replace(" ", "_").replace("-", "_").strip("_")

format = args.format
res = api.Timeboard.get_all()()
res = api.Timeboard.get_all()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the typo ✏️ !

@yannmh
Copy link
Member

yannmh commented Oct 14, 2015

Thanks for the fixes @jhotta !

Rather than having the _pretty_json method defined in multiple sections of the code, what do you think of moving it to a file like datadog/util/format.py directory?

@remh
Copy link

remh commented Oct 16, 2015

@yannmh yup this should be refactored. Can you do it so that we release this bug in a timely fashion please ?

@yannmh
Copy link
Member

yannmh commented Oct 19, 2015

Closing in favor of #92. Thanks @jhotta

@yannmh yannmh closed this Oct 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants