Add tests for options on delete #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dabcoder
reviewed
Jan 14, 2020
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iminoso
force-pushed
the
ian.minoso/add-tests-for-delete-options
branch
from
93a4d5d to
7c5b7aa
Compare
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iminoso
force-pushed
the
ian.minoso/add-tests-for-delete-options
branch
from
7c5b7aa to
e814e30
Compare
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iminoso
force-pushed
the
ian.minoso/add-tests-for-delete-options
branch
from
e814e30 to
1763466
Compare
iminoso
force-pushed
the
ian.minoso/add-tests-for-delete-options
branch
from
1763466 to
3621c7c
Compare
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iminoso
force-pushed
the
ian.minoso/add-tests-for-delete-options
branch
from
94164de to
dc6c69a
Compare
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
armcburney
previously approved these changes
Jan 14, 2020
iminoso
commented
Jan 14, 2020
dabcoder
previously approved these changes
Jan 15, 2020
tests/integration/api/test_api.py
Outdated
| )["data"][0] | ||
|
|
||
| # Check if you can delete the monitor with force option | ||
| options = {"force": True} |
There was a problem hiding this comment.
LGTM. We'll also have to add a note about this options argument in the docs since it currently mentions it dors not take any JSON args: https://docs.datadoghq.com/api/?lang=python#delete-a-monitor once it's live.
jirikuncar
added
changelog/no-changelog
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datadoghq.atlassian.net/browse/MA-791
What does this PR do?
Add tests to confirm correct behavior of using options with the delete method in the client.
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.