Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ApiURL information #314

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

mateo-villa
Copy link
Contributor

@mateo-villa mateo-villa commented Sep 30, 2024

What does this PR do?

The current content is incorrect, as it says ApiURL should only be changed if using a non-US organization. US5 for example would need to specify ApiURL as https://api.us5.datadoghq.com

Description of the Change

Changes non-US to non-US1.

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

The current content is a bit misleading, as it says ApiURL should only be changed if using a non-US organization. This is incorrect, as US5 would need to specify ApiURL as api.us5.datadoghq.com
@mateo-villa mateo-villa requested a review from a team as a code owner September 30, 2024 16:38
@github-actions github-actions bot added the documentation Documentation related changes label Sep 30, 2024
@mateo-villa mateo-villa linked an issue Sep 30, 2024 that may be closed by this pull request
2 tasks
@mateo-villa mateo-villa added the changelog/no-changelog Changes don't appear in changelog label Sep 30, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mateo-villa and others added 2 commits September 30, 2024 13:32
Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>
Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>
@mateo-villa mateo-villa merged commit 071b736 into master Sep 30, 2024
10 checks passed
@mateo-villa mateo-villa deleted the mateo.villa/mateo-villa-patch-1 branch September 30, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog Changes don't appear in changelog documentation Documentation related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApiURL information is unclear for US5
2 participants