-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve resiliency of Ruby SDK when deserializing enums/oneOfs #460
Merged
api-clients-generation-pipeline
merged 15 commits into
master
from
datadog-api-spec/generated/1113
Aug 17, 2021
Merged
Improve resiliency of Ruby SDK when deserializing enums/oneOfs #460
api-clients-generation-pipeline
merged 15 commits into
master
from
datadog-api-spec/generated/1113
Aug 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api-clients-generation-pipeline
bot
requested a review
from a team
as a code owner
August 11, 2021 13:10
therve
reviewed
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor naming questions, otherwise looks great.
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/1113
branch
from
August 12, 2021 13:31
1cf4094
to
365540d
Compare
therve
approved these changes
Aug 16, 2021
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/1113
branch
from
August 16, 2021 13:21
365540d
to
fb222b9
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/1113
branch
from
August 16, 2021 13:59
fb222b9
to
84496c3
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/1113
branch
from
August 16, 2021 15:17
84496c3
to
566364c
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/1113
branch
from
August 16, 2021 15:39
c5afc10
to
fe149c4
Compare
therve
approved these changes
Aug 16, 2021
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/1113
branch
from
August 17, 2021 12:28
d3364e4
to
34ef950
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/1113
branch
from
August 17, 2021 12:42
e8b9398
to
0a1e1f8
Compare
api-clients-generation-pipeline
bot
deleted the
datadog-api-spec/generated/1113
branch
August 17, 2021 13:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#1113
Test branch datadog-api-spec/test/sherz/resiliency