Fix for inflection when your absolute filepath happens to match v[0-9]
#1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the parent structure. This can happen on nix. For example, with a filepath of: /nix/store/xdav9lnh1idxynnqayfr3dclm4i2dmq3-ruby3.2.2-datadog_api_client-2.10.0/lib/ruby/gems/3.2.0/gems/datadog_api_client-2.10.0/lib/datadog_api_client/v1/api/authentication_api.rb You'll attempt to inflect AuthenticationAPI as AuthenticationApi, as we attempt to lookup an override of "v9.authentication_api", which does not exist. (Look closely: `xdav9lnh1idxynnqayfr3dclm4i2dmq3`) has `v9` in it.
therve
approved these changes
Nov 8, 2023
|
Thanks a lot for your fix! |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
…9]` (#1618) in the parent structure. This can happen on nix. For example, with a filepath of: /nix/store/xdav9lnh1idxynnqayfr3dclm4i2dmq3-ruby3.2.2-datadog_api_client-2.10.0/lib/ruby/gems/3.2.0/gems/datadog_api_client-2.10.0/lib/datadog_api_client/v1/api/authentication_api.rb You'll attempt to inflect AuthenticationAPI as AuthenticationApi, as we attempt to lookup an override of "v9.authentication_api", which does not exist. (Look closely: `xdav9lnh1idxynnqayfr3dclm4i2dmq3`) has `v9` in it. b13e6dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix for inflection when your absolute filepath happens to match
v[0-9]in the parent structure. This can happen on nix.For example, with a filepath of:
You'll attempt to inflect AuthenticationAPI as AuthenticationApi, as we attempt to lookup an override of
"v9.authentication_api", which does not exist.(Look closely:
xdav9lnh1idxynnqayfr3dclm4i2dmq3) hasv9in it.Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.