Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to hacky-dev-image-build task to build {process,trace}-agent #29479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Sep 20, 2024

What does this PR do?

Add --process-agent and --trace-agent options back to the agent.hacky-dev-image-build invoke task to also build the process-agent and trace-agent and copy them in the docker image.

Motivation

These options were removed when we migrated to single binary.
But they weren’t added back when the single binary was reverted.

Describe how to test/QA your changes

Run something like

inv agent.hacky-dev-image-build --base-image gcr.io/datadoghq/agent:7.58.0-rc.4 --target-image europe-west3-docker.pkg.dev/datadog-sandbox/lenaic/agent:latest --push --process-agent --trace-agent

and validate that the agent, process-agent and trace-agent inside the docker image are your custom ones.

Possible Drawbacks / Trade-offs

Additional Notes

@L3n41c L3n41c added dev/tooling team/containers qa/no-code-change Skip QA week as there is no code change in Agent code labels Sep 20, 2024
@L3n41c L3n41c added this to the 7.59.0 milestone Sep 20, 2024
@L3n41c L3n41c requested a review from wdhif September 20, 2024 21:36
@L3n41c L3n41c requested a review from a team as a code owner September 20, 2024 21:36
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 44842592 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/tooling qa/no-code-change Skip QA week as there is no code change in Agent code team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants