omnibus: Factorize environment variables forwarding

[chouquette]

What does this PR do?

Factorize the way we forward environment variables to omnibus

Motivation

We'll likely add more in the future, and we can make it simpler to do so

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 44840031 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[chouquette]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 95fae5df-6b4c-49f7-adbe-f1db07f40400 Metrics dashboard Target profiles

Baseline: 4673873
Comparison: 05095c9

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	basic_py_check	% cpu utilization	+0.79	[-1.89, +3.47]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.69	[+0.64, +0.74]	1	Logs
➖	file_tree	memory utilization	+0.00	[-0.11, +0.11]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.09, +0.07]	1	Logs
➖	idle	memory utilization	-0.24	[-0.29, -0.19]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.33	[-1.07, +0.42]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.61	[-1.41, +0.20]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	-1.38	[-3.83, +1.07]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
✅	idle	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".