-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] no trace_pipe with ebpfless #22190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my personal experience the trace pipe does not offer a super great experience. I would be OK with removing it completely. But yeah LGTM
/merge |
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 7cf7c6bc-d59b-45e7-9a6f-3891cfc30b21 Performance changes are noted in the perf column of each table:
Significant changes in experiment optimization goalsConfidence level: 90.00%
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | +0.81 | [-5.77, +7.40] |
➖ | idle | memory utilization | +0.20 | [+0.15, +0.24] |
➖ | file_tree | memory utilization | -0.55 | [-0.69, -0.41] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | otel_to_otel_logs | ingress throughput | +1.41 | [+0.65, +2.17] |
➖ | file_to_blackhole | % cpu utilization | +0.81 | [-5.77, +7.40] |
➖ | idle | memory utilization | +0.20 | [+0.15, +0.24] |
➖ | trace_agent_msgpack | ingress throughput | +0.05 | [+0.03, +0.07] |
➖ | process_agent_standard_check | memory utilization | +0.04 | [-0.03, +0.12] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.03, +0.03] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.05, +0.05] |
➖ | trace_agent_json | ingress throughput | -0.04 | [-0.06, -0.01] |
➖ | process_agent_real_time_mode | memory utilization | -0.06 | [-0.12, -0.01] |
➖ | process_agent_standard_check_with_stats | memory utilization | -0.26 | [-0.32, -0.19] |
➖ | file_tree | memory utilization | -0.55 | [-0.69, -0.41] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.76 | [-0.82, -0.70] |
✅ | uds_dogstatsd_to_api_cpu | % cpu utilization | -5.30 | [-6.68, -3.91] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
🚂 MergeQueue Added to the queue. There are 3 builds ahead of this PR! (estimated merge in less than 1h) Use |
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label, with required eitherqa/done
orqa/no-code-change
labels, are applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.