Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] no trace_pipe with ebpfless #22190

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

safchain
Copy link
Contributor

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@safchain safchain added changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/agent-security labels Jan 19, 2024
@safchain safchain added this to the 7.52.0 milestone Jan 19, 2024
@safchain safchain requested a review from a team as a code owner January 19, 2024 16:42
Copy link
Contributor

@paulcacheux paulcacheux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my personal experience the trace pipe does not offer a super great experience. I would be OK with removing it completely. But yeah LGTM

@safchain safchain added the qa/no-code-change No code change in Agent code requiring validation label Jan 19, 2024
@safchain
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 19, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation.!

@pr-commenter
Copy link

pr-commenter bot commented Jan 19, 2024

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 7cf7c6bc-d59b-45e7-9a6f-3891cfc30b21
Baseline: 3c47e77
Comparison: cfa3a65
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization -5.30 [-6.68, -3.91]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.81 [-5.77, +7.40]
idle memory utilization +0.20 [+0.15, +0.24]
file_tree memory utilization -0.55 [-0.69, -0.41]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +1.41 [+0.65, +2.17]
file_to_blackhole % cpu utilization +0.81 [-5.77, +7.40]
idle memory utilization +0.20 [+0.15, +0.24]
trace_agent_msgpack ingress throughput +0.05 [+0.03, +0.07]
process_agent_standard_check memory utilization +0.04 [-0.03, +0.12]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.03, +0.03]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.05, +0.05]
trace_agent_json ingress throughput -0.04 [-0.06, -0.01]
process_agent_real_time_mode memory utilization -0.06 [-0.12, -0.01]
process_agent_standard_check_with_stats memory utilization -0.26 [-0.32, -0.19]
file_tree memory utilization -0.55 [-0.69, -0.41]
tcp_syslog_to_blackhole ingress throughput -0.76 [-0.82, -0.70]
uds_dogstatsd_to_api_cpu % cpu utilization -5.30 [-6.68, -3.91]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-devflow
Copy link

dd-devflow bot commented Jan 19, 2024

🚂 MergeQueue

Added to the queue.

There are 3 builds ahead of this PR! (estimated merge in less than 1h)

Use /merge -c to cancel this operation.!

@dd-mergequeue dd-mergequeue bot merged commit f12a851 into main Jan 19, 2024
189 of 191 checks passed
@dd-mergequeue dd-mergequeue bot deleted the safchain/no-trace-pipe branch January 19, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card mergequeue-status: done qa/no-code-change No code change in Agent code requiring validation team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants