[RCM-432] fix(remote-config): Clean remote state on error & use fixed fork of go-tuf #13517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbll
reviewed
Sep 15, 2022
arbll
reviewed
Sep 15, 2022
BaptisteFoy
force-pushed
the
baptiste.foy/rcm-432/clean-remote-state-on-error
branch
from
1cbe60c
to
1ff66b6
Compare
BaptisteFoy
force-pushed
the
baptiste.foy/rcm-432/clean-remote-state-on-error
branch
2 times, most recently
from
9fc4882
to
9436cca
Compare
BaptisteFoy
force-pushed
the
baptiste.foy/rcm-432/clean-remote-state-on-error
branch
from
9436cca
to
1a196c8
Compare
arbll
approved these changes
Sep 15, 2022
BaptisteFoy
deleted the
baptiste.foy/rcm-432/clean-remote-state-on-error
branch
BaptisteFoy
added a commit
that referenced
this pull request
Sep 16, 2022
… fork of go-tuf (#13517) * [RCM-432] fix(TUF): Clean remote state on TUF error * fix(go-tuf): Use fork of go-tuf for the time being. * refactor(uptane): Refactor the Update methods
BaptisteFoy
added a commit
that referenced
this pull request
Sep 16, 2022
… fork of go-tuf (#13517) * [RCM-432] fix(TUF): Clean remote state on TUF error * fix(go-tuf): Use fork of go-tuf for the time being. * refactor(uptane): Refactor the Update methods
10 tasks
BaptisteFoy
added a commit
that referenced
this pull request
Sep 16, 2022
… fork of go-tuf (#13517) * [RCM-432] fix(TUF): Clean remote state on TUF error * fix(go-tuf): Use fork of go-tuf for the time being. * refactor(uptane): Refactor the Update methods
BaptisteFoy
added a commit
that referenced
this pull request
Sep 16, 2022
… fork of go-tuf (#13517) * [RCM-432] fix(TUF): Clean remote state on TUF error * fix(go-tuf): Use fork of go-tuf for the time being. * refactor(uptane): Refactor the Update methods
BaptisteFoy
added a commit
that referenced
this pull request
Sep 16, 2022
… fork of go-tuf (#13517) * [RCM-432] fix(TUF): Clean remote state on TUF error * fix(go-tuf): Use fork of go-tuf for the time being. * refactor(uptane): Refactor the Update methods
BaptisteFoy
added a commit
that referenced
this pull request
Sep 16, 2022
* [RCM-132] Send back fetch error to backend (#13282) * Send back fetch error to backend * Fix test * (rcm) improve error reporting (#13382) * [RCM-432] fix(remote-config): Clean remote state on error & use fixed fork of go-tuf (#13517) * [RCM-432] fix(TUF): Clean remote state on TUF error * fix(go-tuf): Use fork of go-tuf for the time being. * refactor(uptane): Refactor the Update methods Co-authored-by: Paul <paul.coignet@datadoghq.com> Co-authored-by: Arthur Bellal <arthur.bellal@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It does two things:
Motivation
Making sure that the agent is bug-less before important deadlines
Additional Notes
Possible Drawbacks / Trade-offs
We are now using a forked version of Go-TUF until we can properly upgrade (upgrade is blocked due to other issues that make Go-TUF non forward compatible).
Describe how to test/QA your changes
Backend has been fixed, so fixing this bug is hard. What you can do is revert https://github.com/DataDog/dd-go/pull/72706, and then do the following, making sure the agent update between each step.
Connecting a client to the agent and continuously querying the agent for configuration should never return an error 500
Also, test restarting the agent locally while disabling WIFI -> Configs should be able to be queried from tracers as if nothing happened.
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.