chore(recipe/consul): enable integration_template usage #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently there is no way to add custom attributes due to hardcoded values in consul.yaml.erb.
|
Closed for inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable integration template usage for consul monitoring.
Motivation
Currently, there is no way to add custom attributes due to hard-coded values in
consul.yaml.erb. For example, it makes impossible to useuse_prometheus_endpointas suggested in consul integration example.Additional Notes
Solves #849
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist