✨ [RUMF-901] allow to run the 'performances' script with rum-recorder #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The devtools protocol does not report request body if they are above a few kb. To work around this limitation, this commit implements a HTTPS server used as a Browser SDK "proxy", capturing the size of all requests sent by the SDK.
The idea is to be able to compare approximately the downloaded resources size that may have an impact on the session-replay size (HTML, stylesheet and scripts (kind of)) to the data that have actually been uploaded to the session-replay intake.
This reverts commit 6d8657b. Results are hard to interpret and adds a bit of noise, let's just remove it for now.
bcaudan
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Measure the Session Replay recorder performance impact on simple scenarios.
Changes
Testing
Manual
I have gone over the contributing documentation.