Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUMF-868] ignore paramaters stored in the hash #792

Merged
merged 1 commit into from
Apr 15, 2021
Merged

[RUMF-868] ignore paramaters stored in the hash #792

merged 1 commit into from
Apr 15, 2021

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

Better support for hash routers.

Changes

Do not take the "search" (anything starting from a ?) part of a hash into account when comparing URLs to generate a new view.

Testing

Unit

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner April 15, 2021 09:50
bcaudan
bcaudan approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenoitZugmeyer BenoitZugmeyer merged commit 4031815 into master Apr 15, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/ignore-hash-params branch April 15, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcaudan bcaudan bcaudan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenoitZugmeyer @bcaudan